View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015333 | Open Gaming Network | [All Projects] General | public | 2018-12-17 12:57 | 2018-12-19 23:08 |
| Reporter | webform | Assigned To | matt | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Summary | 0015333: Table sizes on mobile | ||||
| Description | Issue type: Technical Website Issue Reported from: https://www.d20pfsrd.com/classes/core-classes/cleric/domains by Nathaniel email: nate.d.butler@gmail.com User Agent: Mozilla/5.0 (Linux; Android 8.0.0; SAMSUNG SM-G965U Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/7.4 Chrome/59.0.3071.125 Mobile Safari/537.36 Please stop autosizing tables, or at the very least have a minimum size set; It's okay to scroll left and right. Cleric subdomains are unreadable due to word-wrapping after each character. | ||||
| Tags | d20pfsrd | ||||
|
|
This is down to tables having sizes in percentages ,i.e. "80%" instead of just left to grow to what they need to be. It's on the backlog list to strip out all of those table sizings, they're mostly all left over from the old Google Sites when it was all designed for desktop :( I'll see if there's some way to remove it in client-side javascript in the meantime. |
|
|
Fixed via javascript - now removing all mention of width on tables automatically using jQuery so the browser can size them appropriately |
|
|
Since this change, when viewed on a large screen, the http://www.d20pfsrd.com/equipment/weapons page tables' layouts have become a bit screwy, especially when viewing on a large screen. The simple unarmed and light weapon tables are appearing side-by-side (when viewed on a screen at least 1920 pixels wide) and generally the tables are a bit bunched up, which looks a little messy. Lots of cells end up wrapping onto two rows when there's plenty of room to the side (especially the martial ammunition table). I'm no HTML expert, so I'm not sure how possible this is, but is there a way of making these tables stretch on large screens while maintaining a minimum size? I've had a play around and haven't found anything that works (even just getting the top table to stretch across the screen). |
|
|
Ew. Yeah, that's related to the scrolling div around the outsides of tables, which has "inline-block" set rather than "block", causing them to stack horizontally. Changing that to "block" now. This should give each table the entire "row" to themselves, while allowing it to expand as wide as it needs (it'll still cut off early if it reaches a width that gets everything in, but it should keep growing until it either hits the right of the page or runs out of wrapped lines to unwrap) |
|
|
Changed table wrapping div to "block" rather than "inline-block" |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-12-17 12:57 | webform | New Issue | |
| 2018-12-17 12:57 | webform | Tag Attached: d20pfsrd | |
| 2018-12-18 10:14 | matt | Assigned To | => matt |
| 2018-12-18 10:14 | matt | Status | new => assigned |
| 2018-12-18 10:14 | matt | Note Added: 0002069 | |
| 2018-12-18 10:24 | matt | Status | assigned => resolved |
| 2018-12-18 10:24 | matt | Resolution | open => fixed |
| 2018-12-18 10:24 | matt | Note Added: 0002070 | |
| 2018-12-19 22:33 | JDCalvert | Status | resolved => feedback |
| 2018-12-19 22:33 | JDCalvert | Resolution | fixed => reopened |
| 2018-12-19 22:33 | JDCalvert | Note Added: 0002071 | |
| 2018-12-19 23:04 | matt | Note Added: 0002072 | |
| 2018-12-19 23:05 | matt | Note Edited: 0002072 | View Revisions |
| 2018-12-19 23:08 | matt | Status | feedback => resolved |
| 2018-12-19 23:08 | matt | Resolution | reopened => fixed |
| 2018-12-19 23:08 | matt | Note Added: 0002073 |
